Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Add new linters without code change. Add new disabled linters. #1816

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Matovidlo
Copy link
Contributor

@Matovidlo Matovidlo commented Jun 4, 2024

Jira: PSGO-682

Changes:

  • Add new litners without code changed.

Copy link
Contributor

@michaljurecko michaljurecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ I don't know which which are useful.

@Matovidlo
Copy link
Contributor Author

@michaljurecko About 3 linters are checking the style of code. Most of the linters should prevent unnecessary bugs from using wrong //go: declaratives or checks types passed to the json encoding functions etc. In the comment section I added others. I dont see any reason why we should not use new linters when we use new go version. It should help us and each linter has it's description here https://golangci-lint.run/usage/linters/
So the same reason as you update your libs you update your linters (better code/less code less bugs).

@Matovidlo Matovidlo marked this pull request as draft November 22, 2024 09:33
@Matovidlo Matovidlo marked this pull request as ready for review November 22, 2024 12:46
Copy link
Contributor

@hosekpeter hosekpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matovidlo Matovidlo merged commit b1ba99a into main Nov 25, 2024
12 checks passed
@Matovidlo Matovidlo deleted the lint-add-linters branch November 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants